Set environment when running git commands #3103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git commands often need to shell out to other commands, and so running consistently with the environment set (in particular PATH) fixes issues running in certain environments. Additionally, wrap a few errors to make it easier to determine the reason for failures with the --git-metadata flag.
emcfarlane
approved these changes
Jun 21, 2024
bufdev
approved these changes
Jun 21, 2024
emcfarlane
added a commit
to bufbuild/buf-action
that referenced
this pull request
Jun 26, 2024
Set the min supported version of buf to v1.34.0. This pulls in the required change bufbuild/buf#3103 for better compatibility with different environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git commands often need to shell out to other commands, and so running consistently with the environment set (in particular PATH) fixes issues running in certain environments.
Additionally, wrap a few errors to make it easier to determine the reason for failures with the --git-metadata flag.